Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emrcontainers: Migrate to AWS SDK v2 #38342

Merged
merged 11 commits into from
Jul 19, 2024
Merged

emrcontainers: Migrate to AWS SDK v2 #38342

merged 11 commits into from
Jul 19, 2024

Conversation

mattburgess
Copy link
Collaborator

@mattburgess mattburgess commented Jul 11, 2024 •
edited by jar-b
Loading

Description

Relations

Closes #36159
Relates #32976

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@mattburgess mattburgess requested a review from a team as a code owner July 11, 2024 19:33
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/emrcontainers Issues and PRs that pertain to the emrcontainers service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Jul 11, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@mattburgess mattburgess force-pushed the emrcontainers-awssdkv2-migration branch from b121bee to d2901cf Compare July 11, 2024 19:41
@ewbankkit ewbankkit added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Jul 13, 2024
@ewbankkit ewbankkit self-assigned this Jul 19, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

ewbankkit
ewbankkit approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccEMRContainers' PKG=emrcontainers ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/emrcontainers/... -v -count 1 -parallel 3  -run=TestAccEMRContainers -timeout 720m
=== RUN   TestAccEMRContainersJobTemplate_basic
=== PAUSE TestAccEMRContainersJobTemplate_basic
=== RUN   TestAccEMRContainersJobTemplate_disappears
=== PAUSE TestAccEMRContainersJobTemplate_disappears
=== RUN   TestAccEMRContainersJobTemplate_tags
=== PAUSE TestAccEMRContainersJobTemplate_tags
=== RUN   TestAccEMRContainersVirtualClusterDataSource_basic
=== PAUSE TestAccEMRContainersVirtualClusterDataSource_basic
=== RUN   TestAccEMRContainersVirtualCluster_basic
=== PAUSE TestAccEMRContainersVirtualCluster_basic
=== RUN   TestAccEMRContainersVirtualCluster_disappears
=== PAUSE TestAccEMRContainersVirtualCluster_disappears
=== RUN   TestAccEMRContainersVirtualCluster_tags
=== PAUSE TestAccEMRContainersVirtualCluster_tags
=== CONT  TestAccEMRContainersJobTemplate_basic
=== CONT  TestAccEMRContainersVirtualCluster_basic
=== CONT  TestAccEMRContainersJobTemplate_tags
--- PASS: TestAccEMRContainersJobTemplate_basic (13.32s)
=== CONT  TestAccEMRContainersVirtualClusterDataSource_basic
--- PASS: TestAccEMRContainersJobTemplate_tags (13.73s)
=== CONT  TestAccEMRContainersVirtualCluster_tags
--- PASS: TestAccEMRContainersVirtualCluster_tags (1107.76s)
=== CONT  TestAccEMRContainersVirtualCluster_disappears
--- PASS: TestAccEMRContainersVirtualCluster_basic (1328.87s)
=== CONT  TestAccEMRContainersJobTemplate_disappears
--- PASS: TestAccEMRContainersJobTemplate_disappears (11.58s)
--- PASS: TestAccEMRContainersVirtualClusterDataSource_basic (1363.54s)
--- PASS: TestAccEMRContainersVirtualCluster_disappears (1374.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emrcontainers	2501.026s

@ewbankkit
Copy link
Contributor

@mattburgess Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 396ae6c into hashicorp:main Jul 19, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 19, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@justinretzolk justinretzolk added the external-maintainer Contribution from a trusted external contributor. label Jul 29, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/emrcontainers Issues and PRs that pertain to the emrcontainers service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.59.0
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] EMR Containers Service
3 participants
@mattburgess @ewbankkit @justinretzolk